fix wild cards handling #9066
Merged
fix wild cards handling #9066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangyan99
requested review from
lmazuel and
bryevdv
and removed request for
mayurid
bryevdv
reviewed
Dec 10, 2019
sdk/appconfiguration/azure-appconfiguration/tests/test_azure_configuration_client_aad.py
Outdated
Show resolved
Hide resolved
bryevdv
previously approved these changes
Dec 10, 2019
bryevdv
previously approved these changes
Dec 10, 2019
|
Can one of the admins verify this patch? |
|
/azp run azure-sdk-for-python - update_pr |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Closed
lmazuel
added
AzConfig
Client
lmazuel
reviewed
Dec 12, 2019
| @@ -358,7 +337,7 @@ def test_list_configuration_settings_multi_pages(self): | |||
| pass | |||
|
|
|||
| def test_list_configuration_settings_null_label(self): | |||
| items = self.app_config_client.list_configuration_settings(labels=[""]) | |||
| items = self.app_config_client.list_configuration_settings(label_filter="\0") | |||
There was a problem hiding this comment.
Doesn't seem right, you used to have code code to replace an empty string with "\0" so customer never see "\0", why not keeping it?
There was a problem hiding this comment.
Yes. We used to escape the char for the user and in the new design, we will let user escape it by themselves. This is a change by design.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.